Skip to content

fix: docker #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

fix: docker #432

merged 1 commit into from
Oct 24, 2025

Conversation

@MODSetter
Copy link
Owner

@MODSetter MODSetter commented Oct 24, 2025 •
edited by recurseml bot
Loading

Description

fix: docker config of frontend.

Screenshots

API Changes

  • This PR includes API changes

Change Type

  • Bug fix
  • New feature
  • Performance improvement
  • Refactoring
  • Documentation
  • Dependency/Build system
  • Breaking change
  • Other (specify):

Testing Performed

  • Tested locally
  • Manual/QA verification

Checklist

  • Follows project coding standards and conventions
  • Documentation updated as needed
  • Dependencies updated as needed
  • No lint/build errors or new warnings
  • All relevant tests are passing

High-level PR Summary

This PR fixes the Docker configuration for the frontend service by switching from using a pre-built container image (ghcr.io/modsetter/surfsense_ui:latest) to building the frontend locally from the ./surfsense_web directory. This change allows the frontend to be built with the local codebase rather than pulling a remote image.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 docker-compose.yml

Need help? Join our Discord

Analyze latest changes

Summary by CodeRabbit

  • Chores
    • Updated Docker build configuration for the frontend service to use local build context instead of a pre-built image.
    • Added environment variable configuration for ETL service selection.

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
surf-sense-frontend Building Building Preview Comment Oct 24, 2025 4:05am

@MODSetter MODSetter merged commit 8aeaf41 into main Oct 24, 2025
4 of 6 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Oct 24, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The docker-compose.yml file has been updated to build the frontend service from local source code instead of using a pre-built container image. An environment variable NEXT_PUBLIC_ETL_SERVICE with a default value of DOCLING has been added to the frontend service configuration.

Changes

Cohort / File(s) Summary
Docker Compose Frontend Configuration
docker-compose.yml		 Frontend service switched from using ghcr.io/modsetter/surfsense_ui:latest image (now commented out) to local build context ./surfsense_web. Added environment variable NEXT_PUBLIC_ETL_SERVICE: DOCLING.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 The image fades, the build takes flight,
Local context brings frontend light—
DOCLING whispers through each line,
Configuration divine!
Docker dances, all feels right! 🌊

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1be9c34 and c0e47d6.

📒 Files selected for processing (1)
  • docker-compose.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

recurseml[bot]
recurseml bot reviewed Oct 24, 2025
View reviewed changes
Copy link

@recurseml recurseml bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by RecurseML

🔍 Review performed on 1be9c34..c0e47d6

✨ No bugs found, your code is sparkling clean

✅ Files analyzed, no issues (1)

• docker-compose.yml

recurseml[bot]
recurseml bot reviewed Nov 10, 2025
View reviewed changes
Copy link

@recurseml recurseml bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by RecurseML

🔍 Review performed on c0e47d6..c0e47d6

✨ No files to analyze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@recurseml recurseml[bot] recurseml[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MODSetter